Find/Replace overlay: New/Noteworthy Entry#184
Find/Replace overlay: New/Noteworthy Entry#184HeikoKlare merged 1 commit intoeclipse-platform:masterfrom
Conversation
|
@HannesWell I created this PR following your comment on my PR. |
|
Thanks for providing this.
Sure. :) In general you have already found the right place and after a coarse view it looks good already. The Contributing Guide leads you to more detailed instructions and recommendations about the content and how to validate it: You can try it out by simply opening the modified html file in your browser. It does not look exactly as deployed to the website (I think the theming is missing), but it should give you a good general impression. Once this is submitted it will be published at https://eclipse.dev/eclipse/news/4.33/platform.php shortly later. When you think this is ready I can have a detailed review. |
fedejeanne
left a comment
There was a problem hiding this comment.
Thank you for contributing this!
I just made some corrections based on the instructions.
Could you please also:
- Rename the files to use "-" instead of "_"
- Remove the "noise" (parts from buttons and texts in the background) from the edges of the screenshots
?
7779c53 to
1a45b46
Compare
1a45b46 to
26a4ad4
Compare
|
@fedejeanne @HeikoKlare I have updated the PR according to your suggestions. I have anticipated the merge of the Find/Replace History and already documented it in this PR |
You didn't provide an empty Additionally
|
b5104a8 to
5e0c335
Compare
|
To have this N&N in soon and make people aware of the new feature, I have improved the N&N proposal according to the review and recent changes to the look and feel.
A preview can be seen here: https://htmlpreview.github.io/?https://github.com/Wittmaxi/www.eclipse.org-eclipse/blob/MW_NN_find_replace_overlay/news/4.33/platform.html @fedejeanne could you please have another look? |
fedejeanne
left a comment
There was a problem hiding this comment.
Remove the file .png, it's not necessary.
The rest looks good.
I trust you'll remove the file before merging so it's all good on my side :-)
5e0c335 to
df372a9
Compare
|
Removed the obsolete file in df372a9. |


N&N for eclipse-platform/eclipse.platform.ui#1192